Treat annotations on synthetic parameter properly #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spotbugs/core-devs please review this change, thank you! |
henrik242
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ClassParserUsingASMuses parameter index that doesn't consider the synthetic parameter like the reference from non-static inner class to outer class. This means that, SpotBugs treats annotation on the 1st parameter in source code (Stringin the test case) as annotation on the 1st parameter in bytecode (NonNullParameterOfInnerClassConstructorin the test case).Unfortunately at the timing of
visitParameterAnnotation(), themBuilderdoesn't know that the parameter is synthetic or not. So we need to count the number of synthetic parameters bynumber of actual parameters - number of annotatable parametersdynamically.This PR fixes #772. It also closes #773.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code