Fixed bug with passedValidation property #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var closestDistance = Int.max | ||
|
|
||
| // TODO: Use better name for arrayString parameter | ||
| for arrayString in array { | ||
| let distance = Int(string.levenshteinDistance(from: arrayString)) | ||
|
|
||
| if distance < closestDistance && Float(distance) / Float(string.count) < tolerance { | ||
| if distance < closestDistance, Float(distance) / Float(string.count) < tolerance { |
There was a problem hiding this comment.
Is this just a preference change? (Personally like boolean operators checks like this, so just wondering).
There was a problem hiding this comment.
This is a SwiftFormat thing based on the rules we have defined.
lquigley
reviewed
Dec 17, 2020
Co-authored-by: Kyle Haptonstall <khaptonstall@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @objc public let passedValidation: Bool | ||
|
|
||
| /// The autocorrect suggestion to be applied. Nil if there no suggestion. | ||
| @objc public let autocorrectSuggestion: String? | ||
|
|
||
| @objc public init(passedValidation: Bool, autocorrectSuggestion: String?) { |
There was a problem hiding this comment.
Attributes should be on their own lines in functions and types, but on the same line as variables and imports.attributes SHValidationResult.swift:12 |
Generated by 🚫 Danger |
khaptonstall
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
passedValidationshould be true so long as the incoming/submitted email is in a valid syntax/format. If it isn't, it should actually throw an error. Previously, this was returningfalseif it had no autocorrect suggestion, which was incorrect logic.