Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff failure due to Swift 5.6 Substring hashing change #188

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

kmcbride
Copy link
Collaborator

@kmcbride kmcbride commented Mar 14, 2022

Swift 5.6 appears to have a behavioral change (bug?) related to generating the hashValue for Substring instances. This causes dictionary lookups to miss and the resulting debug diff to contain incorrect data.

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #188 (aea6b68) into master (6f7fec0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head aea6b68 differs from pull request most recent head 95e66a8. Consider uploading reports for the commit 95e66a8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #188   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          42       42           
  Lines        1427     1427           
=======================================
  Hits         1361     1361           
  Misses         66       66           
Flag Coverage Δ
macspm 95.37% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
MobiusTest/Source/SimpleDiff.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7fec0...95e66a8. Read the comment docs.

@kmcbride kmcbride merged commit fd1fb15 into spotify:master Apr 15, 2022
@kmcbride kmcbride deleted the debugdiff-fix branch April 15, 2022 18:59
kmcbride added a commit to kmcbride/Mobius.swift that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants