@synthesize of 'weak' property is only allowed in ARC or GC mode

[loretoparisi]

/MusiXmatch/3rdParty/SPTDataLoader/SPTDataLoader/SPTDataLoaderCancellationTokenImplementation.m:57:13: @synthesize of 'weak' property is only allowed in ARC or GC mode

Is the library a ARC project?

[rastersize]

Hey @loretoparisi,

It’s indeed an ARC project. It looks like you need to init our submodules, which contains an Xcode config file defining almost all of our settings. Including the “use ARC” one.

Running the following command from the root of the project and then re-opening the Xcode workspace should resolve the issue:

git submodule update --init

[loretoparisi]

@rastersize right I initialized the submodules, cleaned up, it fixed that error, but now I get

/MusiXmatch/3rdParty/SPTDataLoader/demo/PlaylistsViewModel.m:113:76: error: implicit conversion from nullable pointer 'NSData * _Nullable' to non-nullable pointer type 'NSData * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
    NSDictionary *jsonDictionary = [NSJSONSerialization JSONObjectWithData:response.body

since the property is nullable

@Property (nonatomic, strong, readonly, nullable) NSData *body;

Ok it's something else since I get this in several locations like:

/MusiXmatch/3rdParty/SPTDataLoader/demo/SPTDataLoaderAuthoriserOAuth.m:141:77: error: implicit conversion from nullable pointer 'NSData * _Nullable' to non-nullable pointer type 'NSData * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
    NSDictionary *tokenDictionary = [NSJSONSerialization JSONObjectWithData:response.body
                                                                            ^
/MusiXmatch/3rdParty/SPTDataLoader/demo/SPTDataLoaderAuthoriserOAuth.m:164:105: error: implicit conversion from nullable pointer 'NSError * _Nullable' to non-nullable pointer type 'NSError * _Nonnull' [-Werror,-Wnullable-to-nonnull-conversion]
            [self.delegate dataLoaderAuthoriser:self didFailToAuthoriseRequest:pendingRequest withError:response.error];

[loretoparisi]

Should'n it an unwrap like

NSDictionary *jsonDictionary=nil;
    NSData *responseBody=response.body;
    if(responseBody) {
        jsonDictionary = [NSJSONSerialization JSONObjectWithData:responseBody
                                                                   options:NSJSONReadingAllowFragments
                                                                     error:&error];
    }

    if (!jsonDictionary) {
        NSLog(@"Error: %@", error);
        return;
    }

[loretoparisi]

I was able to fix after unwrapping all those ones like in AppDelegate.m where I had two:

NSError *error = nil;
    NSDictionary *oauthTokenDictionary = nil;
    NSData *responseBody=response.body;
    if(responseBody) {
       oauthTokenDictionary = [NSJSONSerialization JSONObjectWithData:responseBody
                                                                         options:NSJSONReadingAllowFragments
                                                                           error:&error];
    }

and in

- (void)dataLoader:(SPTDataLoader *)dataLoader didReceiveErrorResponse:(SPTDataLoaderResponse *)response
{
    @synchronized(self.pendingRequests) {
        for (SPTDataLoaderRequest *pendingRequest in self.pendingRequests) {
            NSError *error=response.error;
            [self.delegate dataLoaderAuthoriser:self didFailToAuthoriseRequest:pendingRequest withError:error];
        }
    }
}

[rastersize]

@loretoparisi Ah yes, thank you! I’ve created a PR that should fix these, #105.

[loretoparisi]

+1

the last one was in SPTDataLoaderAuthoriserOAuth.m

here

#pragma mark SPTDataLoaderDelegate

- (void)dataLoader:(SPTDataLoader *)dataLoader didReceiveSuccessfulResponse:(SPTDataLoaderResponse *)response
{
    NSError *error = nil;
    NSDictionary *tokenDictionary = nil;
    NSData *responseBody=response.body;
    if(responseBody) {
        tokenDictionary = [NSJSONSerialization JSONObjectWithData:responseBody
                                                                    options:NSJSONReadingAllowFragments
                                                                      error:&error];
    }

[rastersize]

@loretoparisi Thanks for taking the time to report the issue 🙇🎈

[loretoparisi]

@rastersize you're welcome, thanks for share it, very interesting and useful! Closing then!