Fix the remaining issues with no spotify_shared.xcconfig #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
8W9aG
commented
Jan 22, 2016
8W9aG
commented
- Add some more options to spotify_os.xcconfig
- Make the target inherit these settings
- Fix some more test warnings
- Add a way to allow all certificates through code rather than macros
| * builds. | ||
| * @warning This will trigger an assert if all certificates are allowed on release builds. | ||
| */ | ||
| @property (nonatomic, assign, readwrite, getter = isAllCertificatesAllowed) BOOL allCertificatesAllowed; |
There was a problem hiding this comment.
areAllCertificatesAllowed. But in this case, the getter is probably not important to override.
There was a problem hiding this comment.
👍 Will make the change
|
I re-triggered the failed build. Looked like the simulator flaking out. Fine now ✅ However @8W9aG seems like you’ll need to add some more unit tests 😄 Did notice that Coveralls isn’t able to find the source files from our repo. Not sure why though. See https://coveralls.io/builds/4818416/source?filename=SPTDataLoader%2FSPTDataLoaderService.m. Do you have any ideas why @jgavris? Seems like I’m not an admin at Coveralls so can’t look at the settings 😿 |
* Unsure why these didn't show up before
* Remove SPTDATALOADER_ALLOW_ALL_CERTS
8W9aG
force-pushed
the
add-dynamic-certificates
branch
from
bbe1ef2
to
1b68342
Compare
* The project.xcconfig will get overwritten by our build system when building for the Spotify iOS app * Meanwhile, on the open source build we will continue using the very aggressive spotify_os.xcconfig
|
👍 |
8W9aG
added a commit
that referenced
this pull request
Jan 26, 2016
Fix the remaining issues with no spotify_shared.xcconfig
ChocoChipset
pushed a commit
to ChocoChipset/SPTDataLoader
that referenced
this pull request
Jan 29, 2016
Revert "Merge pull request spotify#38 from peck/fix-for-disabled-headermaps"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.