Add nullability & generic type annotations to all classes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds modern Objective-C annotations to all SPTDataLoader classes, both private and public. Changes include: - Adding NS_ASSUME_NONNULL_BEGIN/END compiler instructions to all files. - Where objects are allowed to be `nil`, add the `nullable` annotation. - Missing `nil`-checks and corresponding `_Nonnull` casts added. - Some missing assignments to required variables added in tests. - Where changes required to fully conform to the nullability annotations were considered too big for this commit, or where whether passing nil would cause a crash was tested, #pragma warning silencers were added. - Generic annotations were added to all collections, both public & private. This change heavily improves SPTDataLoader’s usability in Swift, since arguments that before were typed as `[AnyObject]` now get full typing. Nullable properties and arguments are now also correctly treated as optionals in Swift. This change also has the added benefit of adding more strong typing and safety to the implementation.
| [self.factory requestResponseHandler:nil performRequest:request]; | ||
| #pragma clang diagnostic pop |
There was a problem hiding this comment.
I like _Pragma("clang diagnostic push"), it maintains the indentation level.
There was a problem hiding this comment.
I like it too. In this case though I kind of want the warning silencers to be an eyesore, because we should ideally fix the issue and remove them. I just added them now since it was the smaller change, and I wanted to increase my confidence in the commit my not altering the tests too much. Feel free to change this to whatever code style you prefer though, for me it doesn't matter.
|
👍 |
|
Big like 👍 |
rastersize
added a commit
that referenced
this pull request
Feb 7, 2016
Add nullability & generic type annotations to all classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds modern Objective-C annotations to all SPTDataLoader classes, both private and public.
Changes include:
NS_ASSUME_NONNULL_BEGIN/ENDcompiler instructions to all files.nil, add thenullableannotation.nil-checks and corresponding_Nonnullcasts added.nilwould cause a crash was tested,#pragmawarning silencers were added.Note: Whether a parameter should be
nullableor not was determined by inspecting the surrounding code and the tests.This change heavily improves SPTDataLoader’s usability in Swift, since arguments that before were typed as
[AnyObject]now get full typing. Nullable properties and arguments are now also correctly treated as optionals in Swift.This change also has the added benefit of adding more strong typing and safety to the implementation.