Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currentTimeCallback, do we need it? #20

Closed
ChocoChipset opened this issue Feb 20, 2016 · 4 comments
Closed

currentTimeCallback, do we need it? #20

ChocoChipset opened this issue Feb 20, 2016 · 4 comments
Labels

Comments

@ChocoChipset
Copy link
Contributor

Just wondering if we really need the currentTimeCallback parameter in SPTPersistentCacheOptions.

It makes the API more complex and I'm not sure if it's a common to require something different than the default implementation we provide.

@spotify/objc-dev

@ChocoChipset ChocoChipset changed the title timerCallBack, do we really need it? timerCallBack, do we need it? Feb 20, 2016
@ChocoChipset ChocoChipset changed the title timerCallBack, do we need it? currentTimeCallback, do we need it? Feb 20, 2016
@8W9aG
Copy link
Contributor

8W9aG commented Feb 20, 2016

I do not think we need it 👍

@rastersize
Copy link
Contributor

I agree.

In general we should try to simplify the API. For example by reducing the number of methods on SPTPersistentCache. There are lots of very similar methods that make it difficult to know which to use.

@dflems
Copy link
Contributor

dflems commented Feb 21, 2016

I originally thought we used that for testing purposes. Looks like we don't use it at all. Looks ok to remove 👍

@ChocoChipset
Copy link
Contributor Author

Fixed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants