Simplify API by removing currentTime #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2016 14:19
Remove currentTimeCallback which is not really used for production. Moved custom currentTime mocking to unit test implementation, making the API simpler.
|
Very nice! 👍 The build fails as the Demo app still uses the old API: https://travis-ci.org/spotify/SPTPersistentCache/jobs/110754534#L394 |
|
Oh and please also update the documentation in the readme to reflect the change 😺 |
ChocoChipset
added a commit
that referenced
this pull request
Feb 22, 2016
Simplify API by removing currentTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #20.