You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm triggering the xcmetric binary through scripts and didn't use the launcher. I notice that occasionally xcmetric runs forever when I trigger it without any new xcactivitylog.
I did a very brief skim on the source code, please kindly correct me if I'm wrong:
In MetricUploaderLogic.swift, it seems both cleanedUpLogs and savedUploadRequests need to be received before we can send mobiusLoopCompleted? For my cases, I never received savedUploadRequests.
Then I trace it back to UploadMetricsEffectHandler.swift, line 42, there's an empty check
if !failedURLs.isEmpty {
effects.append(.logsUploadFailed(logs: failedURLs))}
So it seems when nothing fails, the logsUploadFailed will be skipped, and consequently persistNonUploadedLogs will not be triggered, so in the end no savedUploadRequests events will be emitted.
Currently I removed the empty check and it seems to work for my cases now. Have I understood the problem correctly? And will there be any other unwanted side effects if I remove the empty check?
The text was updated successfully, but these errors were encountered:
I'm triggering the
xcmetric
binary through scripts and didn't use the launcher. I notice that occasionallyxcmetric
runs forever when I trigger it without any new xcactivitylog.I did a very brief skim on the source code, please kindly correct me if I'm wrong:
In
MetricUploaderLogic.swift
, it seems bothcleanedUpLogs
andsavedUploadRequests
need to be received before we can sendmobiusLoopCompleted
? For my cases, I never receivedsavedUploadRequests
.Then I trace it back to
UploadMetricsEffectHandler.swift
, line 42, there's an empty checkSo it seems when nothing fails, the
logsUploadFailed
will be skipped, and consequentlypersistNonUploadedLogs
will not be triggered, so in the end nosavedUploadRequests
events will be emitted.Currently I removed the empty check and it seems to work for my cases now. Have I understood the problem correctly? And will there be any other unwanted side effects if I remove the empty check?
The text was updated successfully, but these errors were encountered: