support producer-fast mode for plugin #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polac24
reviewed
Jan 28, 2022
| @@ -47,6 +47,8 @@ class XcodeProjBuildSettingsIntegrateAppender: BuildSettingsIntegrateAppender { | |||
| result["CC"] = wrappers.cc.path | |||
| result["LD"] = wrappers.ld.path | |||
| result["LIBTOOL"] = wrappers.libtool.path | |||
| } else { | |||
| result.removeValue(forKey: "CC") | |||
There was a problem hiding this comment.
This class and function is an appender. I think it shouldn't remove anything. If you want to support build settings deintegration, that should be handled in a separate type.
There was a problem hiding this comment.
Hm. Did not mention class name. Removed it for now
| @@ -169,7 +171,7 @@ def self.enable_xcremotecache(target, repo_distance, xc_location, xc_cc_path, mo | |||
| postbuild_script.dependency_file = "$(TARGET_TEMP_DIR)/postbuild.d" | |||
|
|
|||
| # Mark a sha as ready for a given platform and configuration when building the final_target | |||
| if mode == 'producer' && target.name == final_target | |||
| if (mode == 'producer' || mode == 'producer') && target.name == final_target | |||
There was a problem hiding this comment.
probably a typo for producer-fast
polac24
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These small changes add support for "producer-fast" mode in plugin.
There's also an addition (117-118 lines) where it removes "CC" override in case project was switched from consumer to producer