Resolve symlinks and dirpaths in dependency processor #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update? BTW, can we release new version of plugin (at least) after that PR? |
polac24
approved these changes
Feb 7, 2022
| productPath = product.path.dirPath() | ||
| sourcePath = source.path.dirPath() | ||
| intermediatePath = intermediate.path.dirPath() | ||
| bundlePath = bundle?.path.dirPath() |
There was a problem hiding this comment.
alternatively, we could create initialize URLs in PostbuildContext with init(fileURLWithPath: isDirectory:)
| @@ -72,7 +72,7 @@ class DependencyProcessorImpl: DependencyProcessor { | |||
|
|
|||
| private func classify(_ files: [URL]) -> [Dependency] { | |||
| return files.map { file -> Dependency in | |||
| let filePath = file.path | |||
| let filePath = file.resolvingSymlinksInPath().path | |||
There was a problem hiding this comment.
maybe indeed we should switch to BUILT_PRODUCTS_DIR. For now we can rely on a symlink.
|
Let me release a new library along with a cocoapods plugin tomorrow. Hopefully, that will contain #71. |
|
Available in v0.3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First fix:
Before:
Namethat depend onNameCommon, all artifacts fromNameCommonare filtered out as if they were own artifactsWhat was done:
/symbol to the end of all paths forDependencyProcessorImplNow:
NameandNameCommonartifacts do not interfere each other.Second fix:
Before:
.modulemapandName-Swift.hwere not filtered out inDependencyProcessorImplWhat was done:
TARGET_BUILD_DIRandBUILT_PRODUCTS_DIRdepend on several cases. Generally, they are the same for building. But on archive, they are different, andDependencyProcessorImplusesTARGET_BUILD_DIRto determine ownership of artifacts. But Xcode mostly operates withBUILT_PRODUCTS_DIRto list all dependencies. And, by the way,BUILT_PRODUCTS_DIRis just a symlink toTARGET_BUILD_DIR. So I added resolving symlinks inDependencyProcessorImpl.BUILT_PRODUCTS_DIRinDependencyProcessorImplinstead, but I'm not sure why it isTARGET_BUILD_DIRnow. So I decided just to resolve symlinksNow:
DependencyProcessorImpl.