ensure maps exposed by Request are immutable

spotify · Dec 2, 2015 · c892a55 · c892a55
1 parent ea9ebff
commit c892a55
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/apollo-api/src/main/java/com/spotify/apollo/RequestValue.java b/apollo-api/src/main/java/com/spotify/apollo/RequestValue.java
@@ -58,8 +58,8 @@ private static Request create(
       Optional<ByteString> payload) {
     return new AutoValue_RequestValue(
         method, uri,
-        parameters,
-        headers,
+        ImmutableMap.copyOf(parameters),
+        ImmutableMap.copyOf(headers),
         service,
         payload);
   }

diff --git a/modules/jetty-http-server/src/main/java/com/spotify/apollo/http/server/HttpRequest.java b/modules/jetty-http-server/src/main/java/com/spotify/apollo/http/server/HttpRequest.java
@@ -78,6 +78,12 @@ public static Request create(
       Optional<String> service,
       Map<String, List<String>> parameters,
       Map<String, String> headers) {
-    return new AutoValue_HttpRequest(method, uri, parameters, headers, service, payload);
+    return new AutoValue_HttpRequest(
+        method,
+        uri,
+        ImmutableMap.copyOf(parameters),
+        ImmutableMap.copyOf(headers),
+        service,
+        payload);
   }
 }