This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Dont use executor in StubClient if delay <= 0 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful for tests to have few threads to be more deterministic. There is no reason to schedule responses on an executor if the delay <= 0
Current coverage is 67.68% (diff: 100%)@@ master #135 diff @@
==========================================
Files 137 137
Lines 2811 2813 +2
Methods 0 0
Messages 0 0
Branches 236 237 +1
==========================================
+ Hits 1902 1904 +2
Misses 862 862
Partials 47 47
|
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful for tests to have few threads to be more
deterministic. There is no reason to schedule responses
on an executor if the delay <= 0