This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
ensure failures to respond are logged #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a failure to send a response (for an error or a correctly handled request) to clients would remain 'sitting' in a failed CompletionStage. Partial remediation for spotify#156
Current coverage is 69.20% (diff: 50.00%)@@ 1.x #157 diff @@
==========================================
Files 134 134
Lines 2799 2802 +3
Methods 0 0
Messages 0 0
Branches 224 224
==========================================
+ Hits 1935 1939 +4
Misses 821 821
+ Partials 43 42 -1
|
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a failure to send a response (for an error or a correctly
handled request) to clients would remain 'sitting' in a failed CompletionStage.
Partial remediation for #156