This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Improve outcome logging #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes timeouts, drops and normal responses follow the same code path, and ensures that we won't get IllegalStateExceptions from AsyncContext in 'normal' operation.
Completes changes needed to fix spotify#156.
pettermahlen
force-pushed
the
fix-timeout-logging
branch
from
622d140
to
a37b43d
Compare
Current coverage is 69.59% (diff: 91.56%)@@ 1.x #161 diff @@
==========================================
Files 134 136 +2
Lines 2805 2845 +40
Methods 0 0
Messages 0 0
Branches 224 225 +1
==========================================
+ Hits 1944 1980 +36
- Misses 819 823 +4
Partials 42 42
|
|
+1 Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current, decorator-based, solution for logging request outcomes suffers from
decorators' ability to modify the actual response sent. An example of this is when
the
AsyncContextOngoingRequestrequest processing gets short-circuited by a Jettytimeout, but it can happen in other ways as well. To solve this, this PR makes request
logging a concern of the innermost
OngoingRequestrather than a decorator concern.The same is applicable to request statistics; a timeout today will not be correctly metered. That is intentionally left out of this PR, to be fixed in 2.0 only, instead.