This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Allow loading extra modules for a Service #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.x #320 +/- ##
============================================
+ Coverage 71.73% 71.87% +0.14%
- Complexity 665 667 +2
============================================
Files 135 136 +1
Lines 2848 2852 +4
Branches 166 166
============================================
+ Hits 2043 2050 +7
+ Misses 766 763 -3
Partials 39 39
Continue to review full report at Codecov.
|
apollo-core/src/test/java/com/spotify/apollo/core/ServiceImplTest.java
Outdated
Show resolved
Hide resolved
klaraward
reviewed
Sep 7, 2020
| allModules = Sets.union(modules, ImmutableSet.copyOf(ServiceLoader.load(ApolloModule.class))); | ||
| } else { | ||
| allModules = modules; | ||
| return Sets.union(allModules, ImmutableSet.copyOf(ServiceLoader.load(ApolloModule.class))); |
There was a problem hiding this comment.
We're not doing the deduping against the modules loaded visa ServiceLoader, but I guess that's ok :)
toweroy
approved these changes
Sep 8, 2020
klaraward
approved these changes
Sep 8, 2020
erikjoh
reviewed
Sep 8, 2020
erikjoh
approved these changes
Sep 8, 2020
erikjoh
approved these changes
Sep 8, 2020
erikjoh
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to specify extra set of modules that will always be loaded