Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Fail on dependency:analyze #353

Merged
merged 4 commits into from
May 21, 2021
Merged

Fail on dependency:analyze #353

merged 4 commits into from
May 21, 2021

Conversation

klaraward
Copy link
Contributor

No description provided.

@klaraward klaraward marked this pull request as draft May 18, 2021 13:45
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #353 (f9aacc5) into 1.x (aba3051) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #353      +/-   ##
============================================
+ Coverage     72.04%   72.15%   +0.10%     
  Complexity      673      673              
============================================
  Files           137      137              
  Lines          2862     2862              
  Branches        167      167              
============================================
+ Hits           2062     2065       +3     
+ Misses          763      760       -3     
  Partials         37       37              
Impacted Files Coverage Δ Complexity Δ
...main/java/com/spotify/apollo/core/ServiceImpl.java 91.40% <0.00%> (+1.03%) 35.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba3051...f9aacc5. Read the comment docs.

<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
</dependency>
<!-- <dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was not needed.

@klaraward
Copy link
Contributor Author

Need to figure out why the codecoverage dropped so much in apollo-test

@klaraward klaraward marked this pull request as ready for review May 19, 2021 10:08
Copy link
Contributor

@caesar-ralf caesar-ralf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klaraward klaraward merged commit 34156e7 into 1.x May 21, 2021
@klaraward klaraward deleted the dep-analyze-fail branch May 21, 2021 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants