This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Upgrade guice 4.2.2 -> 5.0.1 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesar-ralf
force-pushed
the
features/upgrade-guice
branch
from
5aa6e54
to
8f3f1af
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #356 +/- ##
=========================================
Coverage 72.04% 72.04%
Complexity 673 673
=========================================
Files 137 137
Lines 2862 2862
Branches 167 167
=========================================
Hits 2062 2062
Misses 763 763
Partials 37 37 Continue to review full report at Codecov.
|
Closed
We are avoid explicitly using the bom because it brings too many transitive dependencies.
caesar-ralf
force-pushed
the
features/upgrade-guice
branch
from
bc8130d
to
0b49032
Compare
klaraward
reviewed
Jun 2, 2021
pom.xml
Outdated
| @@ -76,12 +76,7 @@ | |||
| <dependency> | |||
| <groupId>com.google.inject</groupId> | |||
| <artifactId>guice</artifactId> | |||
To guarantee backwards compatibility. The artifact already comes empty.
klaraward
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Guice from 4.2.2 to 5.0.1.
Why?
User @backuitist asked at issue #350 to do this change to remove a warning. We realized after investigation that guice 4.2.2 is not compatible with Java 16+, which will require us to do this upgrade to 5.0.1 anyway.
Breaking changes
From documentation from their release notes and local tests, there's no breaking changes that we could perceive in Apollo code and its modules besides changes in dependencies.
This upgrade anyway poses a breaking change risk for users using Guice, which will be obligated to also upgrade their versions to match. Our rollout strategy has not been yet determined for this change.
UPDATE
After testing with different projects, there's no change in the API of how Apollo is exposed, neither we could find a significant change in how Guice is used. This means that there's no breaking change perceived in both API and behaviour. With that in mind, I think we can go ahead and release this change to our users as a minor version upgrade