Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Adds more documentation about http modules #363

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Conversation

caesar-ralf
Copy link
Contributor

@caesar-ralf caesar-ralf commented Aug 18, 2021

To improve the situation due to issue #362

@caesar-ralf caesar-ralf force-pushed the improve-http-metric-doc branch 2 times, most recently from f3bb018 to 4c31eac Compare August 18, 2021 09:47
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #363 (5d1394e) into 1.x (70a761b) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #363      +/-   ##
============================================
- Coverage     72.24%   72.15%   -0.10%     
  Complexity      676      676              
============================================
  Files           137      137              
  Lines          2868     2869       +1     
  Branches        169      169              
============================================
- Hits           2072     2070       -2     
- Misses          758      761       +3     
  Partials         38       38              
Impacted Files Coverage Δ
...m/spotify/apollo/http/client/HttpMetricModule.java 0.00% <ø> (ø)
...otify/apollo/http/client/OkHttpClientProvider.java 100.00% <ø> (ø)
...m/spotify/apollo/http/client/HttpClientModule.java 100.00% <100.00%> (ø)
...main/java/com/spotify/apollo/core/ServiceImpl.java 90.37% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a761b...5d1394e. Read the comment docs.

…ient/HttpMetricModule.java

Co-authored-by: Klara <klaraw@spotify.com>
@klaraward klaraward merged commit c1961d2 into 1.x Aug 23, 2021
@klaraward klaraward deleted the improve-http-metric-doc branch August 23, 2021 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants