-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-app: include catalog and scaffolder as part of the template #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rugvip
force-pushed
the
feature/create-app-plugins
branch
from
August 13, 2020 11:43
f43bba5
to
b9dcd46
Compare
Rugvip
force-pushed
the
feature/create-app-plugins
branch
from
August 13, 2020 12:34
924b217
to
af9d127
Compare
6 tasks
Rugvip
force-pushed
the
feature/create-app-plugins
branch
from
August 13, 2020 13:49
f35ed36
to
54fe74e
Compare
Rugvip
force-pushed
the
feature/create-app-plugins
branch
from
August 13, 2020 16:42
54fe74e
to
da5fb05
Compare
timja
approved these changes
Aug 17, 2020
freben
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on top of #1932, towards #1843
Fixes #1824
This adds the Sidebar and APIs to the app, as well as the catalog, scaffolder, and register-component. It also removes the welcome plugin, but internal plugins can still be scaffolded using
yarn create-plugin
It adds static configuration for our example entities and templates as well, which can easily be removed by modifying the config.
This does not make the individual entity pages work, we need more plugins to be installed for that.