refactor: Add ConfidenceInstance and FlagReaderForProvider interfaces
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
telemetry-new-impl2
branch
from
f26c074
to
b6609f5
Compare
fabriziodemaria
force-pushed
the
telemetry-new-impl2
branch
from
b6609f5
to
7c98857
Compare
fabriziodemaria
commented
Jun 20, 2024
Comment on lines
-46
to
-63
| @Test | ||
| public void testCloseChildShouldNotAffectParent() | ||
| throws IOException, ExecutionException, InterruptedException { | ||
| final Confidence child = root.withContext(Map.of("child-key", ConfidenceValue.of("child"))); | ||
| child.close(); | ||
| root.resolveFlags("test", false).get(); | ||
| root.track("test", ConfidenceValue.of(Map.of("messageKey", ConfidenceValue.of("parent")))); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCloseParentShouldAffectChild() throws IOException { | ||
| final Confidence child = root.withContext(Map.of("child-key", ConfidenceValue.of("child"))); | ||
| root.close(); | ||
| assertThrows(IllegalStateException.class, () -> child.resolveFlags("test", false).get()); | ||
| assertThrows(IllegalStateException.class, () -> root.resolveFlags("test", false).get()); | ||
| assertTrue(fakeEngine.closed); | ||
| assertTrue(fakeFlagResolverClient.closed); | ||
| } |
There was a problem hiding this comment.
The child of root.withContext is only an EventSender, doesn't allow resolves. I think this is a limitation we actually wanted to introduce?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildthat returns aConfidenceInstance, for users to resolve and upload events;buildForProvider(meant to be used only by the Confidence Provider), which returns aFlagReaderForProvider: this latter interface allows to callresolvewhile passing in a differentSDK_ID. It also allows to create child resolvers internally, which is instead NOT allowed by the user-facingConfidenceInstance(the latter only allows to create EventSenders as children)Alternative to #146