fix: pageviews: handle missed load event (#148)

spotify · May 29, 2024 · ae6bd43 · ae6bd43
1 parent f5fd2b7
commit ae6bd43
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/sdk/src/trackers/pageViews.ts b/packages/sdk/src/trackers/pageViews.ts
@@ -16,7 +16,7 @@ export function pageViews(): Trackable.Manager {
       },
     });
 
-    return Closer.combine(
+    const listeners = [
       spyOn(history, 'pushState', () => {
         pageChanged({ type: 'pushstate' });
       }),
@@ -28,9 +28,16 @@ export function pageViews(): Trackable.Manager {
       listenOn(window, 'popstate', pageChanged),
 
       listenOn(window, 'hashchange', pageChanged),
+    ];
 
-      listenOn(window, 'load', pageChanged),
-    );
+    // if document is already loaded, call pageChanged otherwise listen for load event
+    if (document.readyState === 'complete') {
+      pageChanged({ type: 'load' });
+    } else {
+      listeners.push(listenOn(window, 'load', pageChanged));
+    }
+
+    return Closer.combine(...listeners);
 
     function pageChanged({ type }: { type: string }) {
       controller.setContext({