Remove single flag resolve function

spotify · Aug 1, 2023 · 24798d8 · 24798d8
1 parent 0e7f89b
commit 24798d8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 25 deletions.
diff --git a/Sources/ConfidenceProvider/ConfidenceClient/ConfidenceClient.swift b/Sources/ConfidenceProvider/ConfidenceClient/ConfidenceClient.swift
@@ -3,7 +3,6 @@ import OpenFeature
 
 public protocol ConfidenceClient {
     func resolve(ctx: EvaluationContext) async throws -> ResolvesResult
-    func resolve(flag: String, ctx: EvaluationContext) async throws -> ResolveResult
 }
 
 public struct ResolvedValue: Codable, Equatable {

diff --git a/Sources/ConfidenceProvider/ConfidenceClient/RemoteConfidenceClient.swift b/Sources/ConfidenceProvider/ConfidenceClient/RemoteConfidenceClient.swift
@@ -55,14 +55,6 @@ public class RemoteConfidenceClient: ConfidenceClient {
         return try await resolve(flags: [], ctx: ctx)
     }
 
-    public func resolve(flag: String, ctx: EvaluationContext) async throws -> ResolveResult {
-        let resolveResult = try await resolve(flags: [flag], ctx: ctx)
-        guard let resolvedValue = resolveResult.resolvedValues.first else {
-            throw OpenFeatureError.flagNotFoundError(key: flag)
-        }
-        return ResolveResult(resolvedValue: resolvedValue, resolveToken: resolveResult.resolveToken)
-    }
-
     // MARK: Private
 
     private func convert(resolvedFlag: ResolvedFlag, ctx: EvaluationContext) throws -> ResolvedValue {

diff --git a/Tests/ConfidenceProviderTests/RemoteConfidenceClientTest.swift b/Tests/ConfidenceProviderTests/RemoteConfidenceClientTest.swift
@@ -22,22 +22,6 @@ class RemoteConfidenceClientTest: XCTestCase {
         super.setUp()
     }
 
-    func testResolveSingleFlagSucceeds() async throws {
-        let session = MockedConfidenceClientURLProtocol.mockedSession(flags: flags)
-        let flagApplier = FlagApplierMock()
-
-        let client = RemoteConfidenceClient(
-            options: .init(credentials: .clientSecret(secret: "test")),
-            session: session,
-            applyOnResolve: true,
-            flagApplier: flagApplier
-        )
-
-        let value = try await client.resolve(flag: "flag1", ctx: MutableContext(targetingKey: "user1"))
-        XCTAssertEqual(resolvedFlag1.value, value.resolvedValue.value)
-        XCTAssertEqual(resolvedFlag1.variant, value.resolvedValue.variant)
-    }
-
     func testResolveMultipleFlagsSucceeds() async throws {
         let session = MockedConfidenceClientURLProtocol.mockedSession(flags: flags)
         let flagApplier = FlagApplierMock()