fix: Provider cache and resolver are accessed safely #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
vahidlazio
previously approved these changes
Apr 29, 2024
|
|
|
New flaky test spotted and hopefully fixed |
fabriziodemaria
force-pushed
the
fix-prop-access
branch
from
de74a00
to
9660204
Compare
|
More errors: |
|
"testResolveAndApplyIntegerFlagError" hopefully fixed in latest commit |
fabriziodemaria
force-pushed
the
fix-prop-access
branch
from
51f6d8d
to
7a1929a
Compare
vahidlazio
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky test, but could reproduce this every 3/4 runs:
