feat: Event Uploader #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
changed the title
vahidlazio
reviewed
Apr 11, 2024
Sources/Confidence/ConfidenceClient/RemoteConfidenceClient.swift
Outdated
Show resolved
Hide resolved
fabriziodemaria
force-pushed
the
http-general
branch
9 times, most recently
from
f05136f
to
94eb067
Compare
fabriziodemaria
force-pushed
the
http-general
branch
2 times, most recently
from
4f2afc8
to
e1be093
Compare
fabriziodemaria
commented
Apr 11, 2024
Sources/Common/NetowrkStruct.swift
Outdated
| } | ||
|
|
||
| enum StructValue: Equatable { | ||
| public enum NetworkStructValue: Equatable { |
There was a problem hiding this comment.
This is basically a JsonObject now! Can we re-use something from Swift/Foundation and delete this completely?
fabriziodemaria
force-pushed
the
http-general
branch
2 times, most recently
from
88e689b
to
5a63cb1
Compare
fabriziodemaria
requested review from
mfranberg,
nicklasl and
nickybondarenko
as code owners
vahidlazio
reviewed
Apr 15, 2024
vahidlazio
reviewed
Apr 15, 2024
vahidlazio
reviewed
Apr 15, 2024
vahidlazio
reviewed
Apr 15, 2024
| switch result { | ||
| case .success(let successData): | ||
| guard successData.response.status == .ok else { | ||
| throw successData.response.mapStatusToError(error: successData.decodedError) |
There was a problem hiding this comment.
if the server returns 401..499 except it was 429 we should consider it a success (as not trying again and removing the events)
vahidlazio
reviewed
Apr 15, 2024
fabriziodemaria
force-pushed
the
http-general
branch
from
5a63cb1
to
3720dd2
Compare
vahidlazio
reviewed
Apr 15, 2024
fabriziodemaria
force-pushed
the
http-general
branch
from
0c397d3
to
910866e
Compare
fabriziodemaria
force-pushed
the
http-general
branch
from
910866e
to
85220c0
Compare
vahidlazio
previously approved these changes
Apr 15, 2024
vahidlazio
previously approved these changes
Apr 15, 2024
fabriziodemaria
force-pushed
the
http-general
branch
from
527e55b
to
d6dbe0a
Compare
vahidlazio
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.