-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Event Uploader #91
Conversation
Sources/Confidence/ConfidenceClient/RemoteConfidenceClient.swift
Outdated
Show resolved
Hide resolved
f05136f
to
94eb067
Compare
4f2afc8
to
e1be093
Compare
Sources/Common/NetowrkStruct.swift
Outdated
} | ||
|
||
enum StructValue: Equatable { | ||
public enum NetworkStructValue: Equatable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically a JsonObject now! Can we re-use something from Swift/Foundation and delete this completely?
88e689b
to
5a63cb1
Compare
switch result { | ||
case .success(let successData): | ||
guard successData.response.status == .ok else { | ||
throw successData.response.mapStatusToError(error: successData.decodedError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the server returns 401..499
except it was 429
we should consider it a success (as not trying again and removing the events)
5a63cb1
to
3720dd2
Compare
0c397d3
to
910866e
Compare
910866e
to
85220c0
Compare
527e55b
to
d6dbe0a
Compare
No description provided.