feat: add listening for context changes #97
Conversation
vahidlazio
changed the title
vahidlazio
requested review from
fabriziodemaria,
mfranberg,
nicklasl and
nickybondarenko
as code owners
vahidlazio
changed the title
| let resolveResult = try await resolve(context: context) | ||
| var removedKeys: [String] = [] | ||
| if let oldContext = oldContext { | ||
| removedKeys = Array(oldContext.asMap().filter { key, _ in !newContext.asMap().keys.contains(key) }.keys) |
There was a problem hiding this comment.
OF.init -> "context1" = 1
Confidence.putContext -> "context1" = 2
OF.init -> "context2" = "abc"
In this case, the final context won't have context1 but we would expect it, right?
There was a problem hiding this comment.
I would say no. if you had some context in your OF and now you set it again without, it means you removed it. I'd remove it here too. (keeping the current behaviour)
There was a problem hiding this comment.
Isn't Confidence (line 2) overriding context1? At this point, that takes precedence
There was a problem hiding this comment.
yes but the set of context using open feature api is also an action which happens later, which takes over the priority again.
There was a problem hiding this comment.
basically the chain of commands from the confidence perspective is :
add context 1 -> commander : OF
change context 1 -> commander: Confidence API
remove context 1 and add context 2 -> commander OF
No description provided.