fix: Improved keys and remove typo #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
fabriziodemaria
force-pushed
the
context-keys
branch
from
50fda2c
to
dc1de71
Compare
nicklasl
approved these changes
May 27, 2024
nicklasl
reviewed
May 27, 2024
| @@ -82,7 +91,7 @@ public class ConfidenceAppLifecycleProducer: ConfidenceEventProducer, Confidence | |||
| return | |||
| } | |||
| var context = self.currentProducedContext.value | |||
| context.updateValue(.init(boolean: isForeground), forKey: "is_foreground") | |||
| context.updateValue(.init(boolean: isForeground), forKey: Self.isForegroundContextKey) | |||
There was a problem hiding this comment.
I think we should reconsider to have this context field at all.
There was a problem hiding this comment.
Can remove in new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIDENCE_VERSIONN_KEYtypoapp_prefix to version and build contexts