feat: add debuglogger to confidence #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
reviewed
Jun 26, 2024
nicklasl
reviewed
Jun 26, 2024
nicklasl
reviewed
Jun 26, 2024
nicklasl
reviewed
Jun 26, 2024
nicklasl
reviewed
Jun 26, 2024
nickybondarenko
requested review from
fabriziodemaria,
mfranberg and
vahidlazio
as code owners
nicklasl
force-pushed
the
debug-for-confidence
branch
from
87da9cf
to
046f47b
Compare
nicklasl
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a DebugLogger to the Confidence SDK. It is utilising OSLog, which is Apple's recommended logging lib that is a replacement for
printandNSLog.DebugLogger can be enabled when creating an initial Confidence instance, but is set to nil as a default. When enabled, it logs some of the pivotal processes of Confidence: event sending, fetching and activating flags, errors.