Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove callbacks from HttpClient #73

Merged
merged 1 commit into from
Jan 30, 2024
Merged

refactor: Remove callbacks from HttpClient #73

merged 1 commit into from
Jan 30, 2024

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Jan 30, 2024 •
edited
Loading

Streamline the network implementation to use async/await across the entire stack.

nicklasl
nicklasl approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement!

@fabriziodemaria fabriziodemaria merged commit 403712a into main Jan 30, 2024
4 checks passed
@fabriziodemaria fabriziodemaria deleted the refactor-callbacks branch January 30, 2024 14:48
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl approved these changes

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabriziodemaria @nicklasl