Ensure that our venv is configured before we try and start any daemons. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to ensure a consistent environment from the 1st and nth install of a package - currently `invoke-rc.d daemon start` is called before we have run our interpreter updates. Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
|
There might be a parallel issue with |
|
The change itself looks good, but could you give some more explanation for the change here? We are talking about the build script, so the '1st and nth install' part escapes me a bit (or it's just my brain being slow on a Monday) |
|
If you look at the generated postinst, the dh_installinit snippet is before the dh_virtualenv one. Thus we can start daemons before we are setup completely. Worse, as daemon starting can be async the behaviour will be non-deterministic :) |
|
Ah, of course! Consider this merged :) |
nailor
added a commit
that referenced
this pull request
Nov 2, 2015
…tscripts-called Ensure that our venv is configured before we try and start any daemons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure a consistent environment from the 1st and nth install
of a package - currently
invoke-rc.d daemon startis called before wehave run our interpreter updates.
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk