This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Fill in additional API methods. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApacheUnixSocket provides API for a client to communicate with an existing unix socket, so the API related to the server-side 'bind' command isn't necessary. They can simply be made to return whichever values indicate an unbound state. Fixes #146
davidxia
force-pushed
the
fill-in-socket-methods
branch
from
e1c4d45
to
d399aff
Compare
|
@rohansingh What do you think? See discussion in the referenced issue. |
|
Looks good to me. 👍 |
davidxia
added a commit
that referenced
this pull request
Jun 8, 2015
Fill in additional API methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApacheUnixSocket provides API for a client to communicate with an
existing unix socket, so the API related to the server-side 'bind'
command isn't necessary. They can simply be made to return whichever
values indicate an unbound state.
Fixes #146