This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
added relocation for the org.glassfish dependency #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
============================================
+ Coverage 66.04% 66.11% +0.06%
Complexity 769 769
============================================
Files 171 171
Lines 3240 3240
Branches 369 369
============================================
+ Hits 2140 2142 +2
+ Misses 940 939 -1
+ Partials 160 159 -1 |
|
@davidxia do you have any comments on this PR? |
davidxia
approved these changes
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with some clashing glassfish dependencies when using docker-client on a payara (glassfish) server. This change fixed it for me. Any reason why you added the org.glassfish pattern in the artifactSet of the shade plugin, but chose to not relocate it? If there is one feel free to ignore this pull request.