Skip to content
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.

Service name can be null #891

Merged
merged 2 commits into from
Sep 14, 2017
Merged

Service name can be null #891

merged 2 commits into from
Sep 14, 2017

Conversation

johnflavin
Copy link
Contributor

If you create a service with a null value for name in ServiceSpec, docker just assigns a name for you. As such, I've marked ServiceSpec.name() @Nullable.

@johnflavin
Copy link
Contributor Author

Test failure appears to be a travis problem. Tons of tests reporting errors that indicate cgroups are not mounted.

@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #891 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #891     +/-   ##
===========================================
- Coverage     66.04%   65.95%   -0.1%     
+ Complexity      769      767      -2     
===========================================
  Files           171      171             
  Lines          3240     3240             
  Branches        369      369             
===========================================
- Hits           2140     2137      -3     
- Misses          940      941      +1     
- Partials        160      162      +2

davidxia
davidxia previously approved these changes Sep 14, 2017
Copy link
Contributor

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add to the changelog?

@johnflavin
Copy link
Contributor Author

Yes, I can. The changelog for this project keeps slipping my mind. You'd think I could remember, since I have one in my project that I have to nag people to add their notes to.

@davidxia davidxia merged commit 002664b into spotify:master Sep 14, 2017
@johnflavin johnflavin deleted the service-name branch September 21, 2017 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants