Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

output/log which containers and images have been deleted #55

Closed
mattnworb opened this issue Oct 5, 2015 · 3 comments · Fixed by #64
Closed

output/log which containers and images have been deleted #55

mattnworb opened this issue Oct 5, 2015 · 3 comments · Fixed by #64

Comments

@mattnworb
Copy link
Member

It would be nice if the script could output in some capacity what it had removed, to be able to trace back issues where an image/container was unexpectedly removed from a host.

The current version of the script keeps some output of what it has done in the "state directory" but this is overwritten each time the script is re-run.

For instance, I would like to be able to check /var/log/cron.log to see that docker-gc deleted image 123456 three hours ago, even if I have run the script 10 times more since then.
@pacuna
Copy link

pacuna commented Oct 6, 2015

+1

1 similar comment
@ryneo
Copy link

ryneo commented Oct 6, 2015

+1

@konstruktoid
Copy link
Contributor

Would a simple ${STATE_DIR}/docker-gc.log log file suffice or are you in need of script output?

@konstruktoid konstruktoid mentioned this issue Oct 12, 2015
Closed
mattnworb pushed a commit to mattnworb/docker-gc that referenced this issue Nov 4, 2015
@konstruktoid @mattnworb
add basic logging. issue spotify#55
f652252 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
mattnworb added a commit to mattnworb/docker-gc that referenced this issue Nov 4, 2015
@mattnworb
send logs to syslog
e3016e9 
Send log messages to syslog so that the log files can be properly rolled
over, split by level/facility, etc.

Facility and level can be configured with $SYSLOG_FACILITY and
$SYSLOG_LEVEL respectively.

Closes spotify#55 and replaces spotify#56. Thanks @konstruktoid!
@mattnworb mattnworb mentioned this issue Nov 4, 2015
Merged
mattnworb pushed a commit to mattnworb/docker-gc that referenced this issue Nov 5, 2015
@konstruktoid @mattnworb
add basic logging. issue spotify#55
c95c17f 
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
mattnworb added a commit to mattnworb/docker-gc that referenced this issue Nov 5, 2015
@mattnworb
send logs to syslog
0f22b37 
Send log messages to syslog so that the log files can be properly rolled
over, split by level/facility, etc.

Facility and level can be configured with $SYSLOG_FACILITY and
$SYSLOG_LEVEL respectively.

Closes spotify#55 and replaces spotify#56. Thanks @konstruktoid!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log docker-gc activity to syslog mattnworb/docker-gc
4 participants
@mattnworb @pacuna @ryneo @konstruktoid