Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Add DRY_RUN option #94

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Add DRY_RUN option #94

merged 1 commit into from
Mar 23, 2016

Conversation

zerthimon
Copy link
Contributor

This patch provides DRY_RUN option to test the settings before the run.
ex:

DRY_RUN=1

@zerthimon zerthimon mentioned this pull request Mar 4, 2016
fix wrong logger, wrong message and wrong image list file
@mbruggmann
Copy link
Member

Could you squash your commits? 👍 for the functionality

@zerthimon
Copy link
Contributor Author

zerthimon@a3b2d2a
Hm, this commit is the squash, I thought.

@zerthimon
Copy link
Contributor Author

@mbruggmann anything else I can do to make this PR merged ?

@emmetog
Copy link

emmetog commented Mar 18, 2016

@zerthimon the PR now has 4 commits in it, when you've squashed all the commits into one there will only be 1 single commit in this PR.

Here's a guide that might help you:
https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

@zerthimon
Copy link
Contributor Author

@emmetog @mbruggmann

PR is fixed
(the wrong step from my side was to merge after rebase, had to do forced commit)

@mattnworb
Copy link
Member

@zerthimon thanks!

@mattnworb mattnworb merged commit fa99444 into spotify:master Mar 23, 2016
@DeviaVir
Copy link
Contributor

@mattnworb @mbruggmann the docker build for this change failed, any chance you could kick it?
https://hub.docker.com/r/spotify/docker-gc/builds/bhxisqpuqaotobglstrba58/

@mattnworb
Copy link
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants