Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Support for private docker registry? #8

Closed
ghost opened this issue Feb 13, 2017 · 4 comments
Closed

Support for private docker registry? #8

ghost opened this issue Feb 13, 2017 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 13, 2017

Hi,

I would like to know if this plugin officially supports pulling from a private docker registry?

I get authentication issue when I try to pull from an image from a private docker registry.

Thanks
@Systemmanic
Copy link

Any clarification on this? I also get an auth error.

@mattnworb
Copy link
Member

FYI we are planning improvements in spotify/docker-client#740 that should make it easier for this project to support authentication once 740 is complete.

@jpwijbenga
Copy link

jpwijbenga commented Jun 1, 2017 •
edited

I'd like to have some more info in the readme on whether the plugin supports authentication for a private registry.
I tried to push to a private Gitlab CI registry using this plugin, but got a 'Forbidden' response from the registry. Probably, because I didn't do a 'docker login', I think.
It would be nice to have some info in the readme about authentication (also add if it's not supported yet). And thanks for the plugin. :)

@mattnworb mattnworb mentioned this issue Jun 5, 2017
Closed
@mattnworb
Copy link
Member

v1.3.0 of the plugin adds support for reading the authentication info from your ~/.dockercfg or ~/.docker/config.json file, see the README for more.

petesavitsky pushed a commit to NYSHEX/dockerfile-maven that referenced this issue Jan 2, 2019
@dflemstr
Initial release of the internal repository.
d224181 
Squashed commit of the following:

commit 74bb33d5debb64ed562b53ed3fc637456334cbd9
Author: David Flemström <dflemstr@spotify.com>
Date:   Sat Mar 12 19:07:56 2016 +0100

    Encourage using global configuration

commit 9b0853461f533c848232fea695477a357c1b9ddc
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 9 14:25:05 2016 +0100

    [maven-release-plugin] prepare for next development iteration

commit 6ca4b60
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 9 14:25:02 2016 +0100

    [maven-release-plugin] prepare release v1.1.1

commit 4671ad8
Merge: 0aa58cb 1a999bf
Author: David Flemström <dflemstr@spotify.com>
Date:   Tue Oct 20 17:29:46 2015 +0200

    Merge pull request spotify#8 from martina/martina/check-dockerfile-exists

    Check that the dockerfile exists before building

commit 1a999bf
Merge: 591d741 7a32864
Author: Martina Iglesias <martina@spotify.com>
Date:   Tue Oct 20 17:28:39 2015 +0200

    Merge pull request #1 from dflemstr/martina/check-dockerfile-exists

    Fix the PR

commit 7a32864
Author: David Flemström <david.flemstrom@gmail.com>
Date:   Sun Oct 18 17:04:12 2015 +0200

    Maybe it's good to actually assert something

commit fa46cd6
Author: David Flemström <david.flemstrom@gmail.com>
Date:   Sun Oct 18 17:02:12 2015 +0200

    Fix verification script for missing dockerfile test

commit 1c4bc92
Author: David Flemström <david.flemstrom@gmail.com>
Date:   Sun Oct 18 16:44:13 2015 +0200

    Name tests differently so I can check out repo on Windows

commit 591d741
Author: Martina Iglesias <martina@spotify.com>
Date:   Thu Oct 15 19:35:20 2015 +0200

    Add some tests

commit cab82dd
Author: Martina Iglesias <martina@spotify.com>
Date:   Thu Oct 15 18:05:38 2015 +0200

    Check that the dockerfile exists before building

commit 0aa58cb
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Oct 12 17:54:22 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit c89c80f
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Oct 12 17:54:20 2015 +0200

    [maven-release-plugin] prepare release v1.1.0

commit 8f0e8f5
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Oct 12 17:46:43 2015 +0200

    Make pulling base images configurable

commit eac7c27
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Oct 12 17:46:23 2015 +0200

    Update IT base images to ones that exist

commit 3334ee9
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Oct 12 17:38:25 2015 +0200

    Pull newer base images if possible

commit b4a2608
Author: Rouzbeh Delavari <rouz@spotify.com>
Date:   Wed Oct 7 15:40:48 2015 +0200

    Update lib-info.yaml

commit 04e1075
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 13:36:34 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit c1e2c4d
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 13:36:31 2015 +0200

    [maven-release-plugin] prepare release v1.0.0

commit 33a71b2
Merge: 0efda16 5bdaf32
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 13:32:39 2015 +0200

    Merge pull request spotify#7 from java/retry

    Implement retry behavior for intermittent Docker failures

commit 5bdaf32
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 13:26:16 2015 +0200

    Warn when retrying

commit 4a1a1d9
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 13:06:29 2015 +0200

    Implement retry behavior for intermittent Docker failures

commit 0efda16
Merge: 33a8736 23efbd1
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 11:57:40 2015 +0200

    Merge pull request spotify#6 from java/skip

    Skip execution

commit 23efbd1
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 10:47:36 2015 +0200

    Add individual goal skip parameters

commit b93828a
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 10:42:31 2015 +0200

    Add integration test for skip behavior

commit 6f13dbb
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Sep 25 10:15:59 2015 +0200

    Add a global 'skip' flag

commit 33a8736
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Sep 24 17:45:12 2015 +0200

    (Redacted Spotify internal commit message)

commit 379d36c
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Aug 12 11:17:29 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit 66411ce
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Aug 12 11:17:27 2015 +0200

    [maven-release-plugin] prepare release v0.5.2

commit 6aa707e
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Aug 12 11:16:59 2015 +0200

    Deploy to plugins Maven repo instead of libs Maven repo

commit 6771db1
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Aug 6 09:28:06 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit 3bd1596
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Aug 6 09:28:03 2015 +0200

    [maven-release-plugin] prepare release v0.5.1

commit f177f96
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Aug 6 09:13:03 2015 +0200

    Auto-version submodules

commit 2b3512d
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Aug 6 09:11:57 2015 +0200

    Correct extension dependency version that got out of sync

commit 7c213e3
Merge: 72b4635 ee77a54
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jul 9 09:05:48 2015 +0200

    Merge pull request spotify#4 from magneto/correct-timeouts

    Correct connection time outs to match comments

commit ee77a54
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jul 9 08:59:53 2015 +0200

    Correct connection time outs to match comments

commit 72b4635
Merge: 5950941 05f8e7a
Author: David Flemström <dflemstr@spotify.com>
Date:   Mon Jul 6 22:19:49 2015 +0200

    Merge pull request #3 from dxia/patch-1

    Upgrade helios testing dependencies

commit 05f8e7a
Author: David Xia <dxia@spotify.com>
Date:   Mon Jul 6 13:41:56 2015 -0400

    Upgrade helios testing dependencies

    Newer versions of helios-testing generates helios integration test reports.
    See these PRs:

    * spotify/helios#498
    * spotify/helios#499
    * spotify/helios#501

commit 5950941
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jul 2 16:54:17 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit 87289c3
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jul 2 16:54:14 2015 +0200

    [maven-release-plugin] prepare release v0.5.0

commit 4d8509d
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Jul 1 14:17:55 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit c01dea3
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Jul 1 14:08:55 2015 +0200

    Remove helios testing profile override

commit d9dca82
Merge: 103abc8 4df912b
Author: Mikael Goldmann <migo@spotify.com>
Date:   Wed Jul 1 13:50:52 2015 +0200

    Merge pull request #2 from magneto/timeouts

    Control timeouts to docker daemon and set defaults to 5min

commit 4df912b
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Jul 1 13:48:44 2015 +0200

    Control timeouts to docker daemon and set defaults to 5min

commit 103abc8
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:55:39 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit 17e1903
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:55:36 2015 +0200

    [maven-release-plugin] prepare release v0.4.0

commit ef15d15
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:47:46 2015 +0200

    Enable re-tagging integration tests again

commit ee2d09f
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:47:32 2015 +0200

    Simplify plugin dependencies a bit

commit 407103e
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:47:03 2015 +0200

    Fix problem where metadata dir could not be overwritten

commit 36e794f
Merge: 4443d09 f3aa54d
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:42:37 2015 +0200

    Merge pull request #1 from magneto/test-classpath-metadata

    Write image information to test classpath for easier discovery

commit f3aa54d
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:39:28 2015 +0200

    Rename new test case to have its own artifactId

commit 93dc82a
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Jun 4 10:28:00 2015 +0200

    Write image information to test classpath for easier discovery

commit 4443d09
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Apr 24 12:08:22 2015 +0200

    [maven-release-plugin] prepare for next development iteration

commit 248363a
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Apr 24 12:08:20 2015 +0200

    [maven-release-plugin] prepare release v0.3.2

commit c9cd0b1
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Apr 24 12:04:41 2015 +0200

    Correctly separate multiple lines of output in Docker build output

commit 743f647
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Apr 24 12:02:49 2015 +0200

    Enable support for force-retagging

commit bf79179
Author: David Flemström <dflemstr@spotify.com>
Date:   Fri Apr 24 12:02:38 2015 +0200

    Upgrade Docker client

commit bd4b6b0
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 18:17:04 2015 +0100

    Update README.md

commit b050bf4
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 16:56:17 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit 27a9ab3
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 16:56:15 2015 +0100

    [maven-release-plugin] prepare release v0.3.1

commit 470f4d2
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 16:52:21 2015 +0100

    Disable dependency inclusion for docker-info artifacts

commit cb74873
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 14:38:10 2015 +0100

    Correct the scope of the advanced IT test dependencies

commit 909c909
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 14:31:23 2015 +0100

    Fix broken links

commit 6940da3
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 13:35:54 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit 8f0d45e
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 13:34:58 2015 +0100

    [maven-release-plugin] prepare release v0.3.0

commit 6d7805b
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 12:46:06 2015 +0100

    Change title of README

commit f1978da
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 12:44:08 2015 +0100

    Fix mini typo

commit fd24939
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 12:30:11 2015 +0100

    Add extension information to README

commit 0b8440e
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 12:30:03 2015 +0100

    Add Maven extension and use it in ITs

commit fca1de3
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 12:18:44 2015 +0100

    Move plugin into sub-directory

commit 216ee89
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:49:06 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit 07160b9
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:49:04 2015 +0100

    [maven-release-plugin] prepare release v0.2.1

commit 8e3f776
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:46:56 2015 +0100

    Add more spacing!

commit c3169f6
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:41:21 2015 +0100

    Add paragraph about advanced IT

commit 94bc782
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:33:46 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit 777ee6d
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:33:43 2015 +0100

    [maven-release-plugin] prepare release v0.2.0

commit 359932a
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:32:01 2015 +0100

    Add some log spacing

commit e383f42
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:30:42 2015 +0100

    Add verbose output flag and make it impact the pull/push reporting

commit 01f8f9e
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:24:30 2015 +0100

    Don't escape image IDs and names, because it's inconvenient

commit ca8a349
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:22:55 2015 +0100

    Refactor example IT

commit ec9577c
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:19:16 2015 +0100

    Stream logs for ITs

commit 4b3bbc0
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:18:57 2015 +0100

    Add advanced integration test that uses helios-testing

commit 9a644e1
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 11:04:44 2015 +0100

    Exclude ITs that don't work because of a Java Docker client API bug

commit 0508e50
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 10:41:23 2015 +0100

    Switch to Spotify's Docker library

commit 32baa43
Author: David Flemström <dflemstr@spotify.com>
Date:   Thu Mar 26 09:50:10 2015 +0100

    Print final build status

commit b8578c9
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:37:35 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit fcc582e
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:37:32 2015 +0100

    [maven-release-plugin] prepare release v0.1.1

commit c4ebae4
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:35:35 2015 +0100

    Add the usual Spotify build files

commit 816698d
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:35:20 2015 +0100

    Bump plugin versions

commit 94e93e7
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:30:42 2015 +0100

    [maven-release-plugin] prepare for next development iteration

commit 949b5e6
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:30:40 2015 +0100

    [maven-release-plugin] prepare release v0.1.0

commit 2848de2
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:29:02 2015 +0100

    Add release plugin + the usual distribution stuff

commit 7f73c93
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:16:46 2015 +0100

    Add link to integration tests

commit 735fb3c
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 19:15:30 2015 +0100

    Add README.md

commit 0f967f8
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 18:40:50 2015 +0100

    Add a multi-module example with working cross-dependencies

commit 0d28982
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 18:40:26 2015 +0100

    Package docker-info as type JAR

commit 93e61fe
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 18:40:14 2015 +0100

    Fix IT artifact IDs to be distinct

commit 2930eb6
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 18:18:02 2015 +0100

    Add basic plugin that does most of what we want

commit 125732e
Author: David Flemström <dflemstr@spotify.com>
Date:   Wed Mar 25 12:52:54 2015 +0100

    Initial commit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattnworb @Systemmanic @jpwijbenga