Add connection timeout to job submitter script #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regadas
approved these changes
Nov 8, 2021
regadas
reviewed
Nov 8, 2021
| local success_count=0 | ||
|
|
||
| echo_log "Checking job manager to be ready. Will check success of ${REQUIRED_SUCCESS_NUMBER} API calls for stable job submission." "job_check_log" | ||
| for ((i = 1; i <= MAX_RETRY; i++)); do | ||
| echo_log "curl -sS \"http://${FLINK_JM_ADDR}/jobs\"" "job_check_log" | ||
| if curl -sS "http://${FLINK_JM_ADDR}/jobs" 2>&1 | tee -a job_check_log; then | ||
| if curl -sS --connect-timeout ${CONNECT_TIMEOUT} "http://${FLINK_JM_ADDR}/jobs" 2>&1 | tee -a job_check_log; then |
There was a problem hiding this comment.
We should definitely replace this logic with proper curl retry since it supports it nicely. This is for a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a new cluster, the submitter is hanging by
curl -sS "http://jobmanager:8081/jobs"for a long time until the default timeout of 120s because the jobmanager is not yet ready.Adding
--connect-timeout <seconds>to solve this problem.