Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

downgrade to scio 0.6.1 #204

Merged
merged 2 commits into from Jan 17, 2019
Merged

downgrade to scio 0.6.1 #204

merged 2 commits into from Jan 17, 2019

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Jan 16, 2019

Hey, I just made a Pull Request!

Description

support latest stable scio version.

Motivation and Context

Have you tested this? If so, how?

Checklist for PR author(s)

  • Changes are covered by unit test
  • All tests pass
  • Code coverage check passes
  • Error handling is tested
  • Errors are handled at the appropriate layer
  • Errors that cannot be handled where they occur are propagated
  • Relevant documentation updated
  • This PR has NO breaking change to public API
  • This PR has breaking change to public API and it is documented

Checklist for PR reviewer(s)

  • This PR has been incorporated in release note for the coming version
  • Risky changes introduced by this PR have been all considered

@honnix
Copy link
Contributor Author

honnix commented Jan 16, 2019

I removed missinglink because the error message is impossible to read in this case.

Plus I verified this works for flo-example.

@honnix honnix mentioned this pull request Jan 16, 2019
Merged
11 tasks
@honnix honnix merged commit dd10ab9 into upgrade-bq-client Jan 17, 2019
@honnix honnix deleted the scio-0.6.1 branch January 17, 2019 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielnorberg danielnorberg danielnorberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@honnix @danielnorberg