Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region and kubernetes cluster options #305

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

smikloska
Copy link
Contributor

No description provided.

protos/flyteidl-flink/flink.proto Outdated Show resolved Hide resolved
@live-wire live-wire merged commit c1f105d into master Jul 27, 2023
2 checks passed
@live-wire live-wire deleted the stefaniem/add-region-kubernetes-ops branch July 27, 2023 12:01
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. Can we just expand on the functionality that this introduces. Also out of curiosity couldnt we accomplished the same with annotations? It seems more appropriate to me if I’m understanding this correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants