Add lambda friendly addCallback. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. My only concern is that we allow null for the consumers (for one or for both). |
| You can attach callbacks that are run depending on the results of a future: | ||
| ```java | ||
| final ListenableFuture<A> future = getFuture(); | ||
| FuturesExtra.addCallback(future, a -> System.out.println(a), e -> e.printStackTrace()); |
There was a problem hiding this comment.
this example could also use method references: System.out::println and Throwable::printStackTrace
| * only be run if the future fails. | ||
| * @param future a ListenableFuture to attach the callbacks to. | ||
| * @param success a consumer, to be called with the result of the successful future. | ||
| * @param failure a consumer, to be called with the result of the failed future. |
There was a problem hiding this comment.
document the nullability-rules of the parameters (both may not be null)
| * @param future a ListenableFuture to attach the callbacks to. | ||
| * @param success a consumer, to be called with the result of the successful future. | ||
| * @param failure a consumer, to be called with the result of the failed future. | ||
| * @throws NullPointerException if the {@param success} and {@param failure} are null |
There was a problem hiding this comment.
this is slightly unclear (not obvious that both have to be null for it to throw) but i dont want to reject the change based on that.
spkrka
added a commit
that referenced
this pull request
Oct 30, 2015
Add lambda friendly addCallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.