Add rationale for FuturesExtra.syncTransform #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review? @noaresare @mbruggmann @rschildmeijer |
|
Coverage remained the same at 76.67% when pulling 38060b53b3a36502aa5d68b90a1119c5786f0b36 on krka/readme into 91ab270 on master. |
| ``` | ||
|
|
||
| This doesn't actually work though, because Futures.transform has two variants: one that takes a Function and one that takes an AsyncFunction. | ||
| This confuses the compiler so it can't determine which variant you want to use. |
There was a problem hiding this comment.
Maybe Hence the compiler can't determine which variant to use without additional type information?
|
Minor nitpick, otherwise 👍 |
spkrka
added a commit
that referenced
this pull request
Feb 21, 2015
Add rationale for FuturesExtra.syncTransform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.