Conversions from ApiFuture to CompletableFuture #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmmile
force-pushed
the
emilio/apifuture
branch
from
a393e05
to
13fbc6b
Compare
spkrka
reviewed
Nov 16, 2018
| @Test | ||
| public void testToCompletableFutureFromApiFutureUnwrap() { | ||
| final ApiFuture<String> apiFuture = SettableApiFuture.create(); | ||
| CompletableFuture<String> wrapped = toCompletableFuture(apiFuture); |
spkrka
approved these changes
Nov 16, 2018
spkrka
pushed a commit
that referenced
this pull request
Nov 16, 2018
* conversions from ApiFuture to CompletableFuture * adding tests for ApiFuture to CompletableFuture * make apifuture wrapper more inline with listenablefuture wrapper * implemented tests for CompletableFuture to ApiFuture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@balaji we will need to add tests.