Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Bump folsom to 1.2.1 as it fixes a connection leak #395

Merged
merged 1 commit into from Nov 15, 2018

Conversation

jsferrei
Copy link
Collaborator

@jsferrei jsferrei commented Nov 9, 2018

@dmichel1 I'm going to run some quick tests on this first but spotify/folsom#103 has been fixed in 1.2.1

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #395 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #395     +/-   ##
===========================================
- Coverage     46.91%   46.81%   -0.1%     
+ Complexity     2692     2690      -2     
===========================================
  Files           644      646      +2     
  Lines         17606    17634     +28     
  Branches       1283     1283             
===========================================
- Hits           8260     8256      -4     
- Misses         8871     8901     +30     
- Partials        475      477      +2
Impacted Files Coverage Δ Complexity Δ
.../heroic/statistics/noop/NoopMemcachedReporter.java 0% <0%> (ø) 0 <0> (?)
...ic/statistics/semantic/SemanticHeroicReporter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ify/heroic/statistics/noop/NoopHeroicReporter.java 84.61% <0%> (-7.06%) 11 <0> (ø)
...gest/elasticsearch/ElasticsearchSuggestModule.java 59.45% <0%> (-0.55%) 6 <0> (ø)
...ata/elasticsearch/ElasticsearchMetadataModule.java 59.64% <0%> (-0.53%) 6 <0> (ø)
...statistics/semantic/SemanticMemcachedReporter.java 0% <0%> (ø) 0 <0> (?)
...m/spotify/heroic/aggregation/simple/MaxBucket.java 42.85% <0%> (-9.53%) 4% <0%> (-1%)
...m/spotify/heroic/aggregation/simple/MinBucket.java 42.85% <0%> (-9.53%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000e387...a55defe. Read the comment docs.

@jsferrei jsferrei force-pushed the jsferrei/update-folsom branch 5 times, most recently from 460e309 to 7ce6749 Compare November 9, 2018 15:31
@dmichel1
Copy link
Contributor

dmichel1 commented Nov 9, 2018

LGTM -

re: memcached metrics there is also a way to enable the semantic metrics that are part of the folsom client, https://github.com/spotify/folsom/blob/master/folsom-semantic-metrics/src/main/java/com/spotify/folsom/client/SemanticFolsomMetrics.java.

Your approach allows for finer grained metrics since its per consumer-type.

@jsferrei jsferrei force-pushed the jsferrei/update-folsom branch 2 times, most recently from b148676 to 883d235 Compare November 15, 2018 18:28
@jsferrei jsferrei merged commit ea1e626 into spotify:master Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants