Skip to content
This repository has been archived by the owner on Mar 27, 2021. It is now read-only.

Fix a couple of issues with Heroic minimal setup #529

Merged
merged 2 commits into from Aug 21, 2019
Merged

Conversation

hexedpackets
Copy link
Contributor

  • Fix the cache example config
  • Add an entrypoint to the docker image. Right now, trying to run the command in the README for Docker will just start a bash shell

@project-bot project-bot bot added this to In progress in Observability Kanban Aug 20, 2019
@hexedpackets hexedpackets requested a review from a team August 20, 2019 14:12
@project-bot project-bot bot moved this from In progress to Waiting for review in Observability Kanban Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #529 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #529      +/-   ##
============================================
+ Coverage     49.69%   49.71%   +0.01%     
- Complexity     2899     2905       +6     
============================================
  Files           720      722       +2     
  Lines         19841    19849       +8     
  Branches       1434     1434              
============================================
+ Hits           9860     9867       +7     
- Misses         9487     9488       +1     
  Partials        494      494
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/spotify/heroic/test/Points.java 100% <0%> (ø) 3% <0%> (?)
...st/src/main/java/com/spotify/heroic/test/Data.java 66.66% <0%> (ø) 2% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a69fb...1245b7c. Read the comment docs.

@hexedpackets hexedpackets merged commit d949f7e into master Aug 21, 2019
Observability Kanban automation moved this from Waiting for review to Ready to deploy Aug 21, 2019
@hexedpackets hexedpackets deleted the quickstart branch August 21, 2019 18:24
@malish8632 malish8632 moved this from Ready to deploy to Done in Observability Kanban Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants