Changes to allow the use of Elasticsearch 2x. #62

dbrounst · 2016-07-21T17:58:17Z

Special thanks to bwen@ciena.com, jocabera@ciena.com and dbrounst@ciena.com

udoprog · 2016-07-22T16:47:11Z

Hey,

Thanks for the contribution!
Please fix up the Travis errors and I'll give this a review at the beginning of next week.

Before merging I'll be running the integration tests as documented in the README. If you haven't, I recommend you do this before to iron out any potential issues without having to round-trip with me.

HeroicShell should return exit code 1 in case of errors

- Fixed issues for full test suite. - Fixed NOT query filter - Fixed "path.home" not configured issue for unit test.

…thub # Conflicts: # heroic-elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/TransportClientSetup.java # heroic-elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/index/SingleIndexMapping.java # metadata/elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendKV.java # metadata/elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendV1.java # suggest/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendKV.java # suggest/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendV1.java

Elasticsearch 2x GitHub

# Conflicts: # heroic-elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/TransportClientSetup.java # heroic-elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/index/SingleIndexMapping.java # metadata/elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendKV.java # metadata/elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendV1.java # suggest/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendKV.java # suggest/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendV1.java

…icsearch-2x

codecov-io · 2016-09-16T17:52:05Z

Current coverage is 20.15% (diff: 21.59%)

No coverage report found for master at 96b989b.

Powered by Codecov. Last update 96b989b...730f3b2

udoprog

Please rebase and remove some of the merge commits. Also avoid including the HeroicShell change since its being merged separately.

udoprog · 2016-09-18T16:19:18Z

heroic-elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/NodeClientSetup.java

@@ -49,6 +50,8 @@ public Client setup() throws Exception {
            .put("node.name", InetAddress.getLocalHost().getHostName())
            .put("discovery.zen.ping.multicast.enabled", false)
            .putArray("discovery.zen.ping.unicast.hosts", seeds)
+            // Fixing path.home not configured error in unit test
+            .put("path.home", "/tmp/" + UUID.randomUUID())


Make use of Files.createTempDirectory() since it does the right thing already.

udoprog · 2016-09-18T16:22:33Z

...lasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/StandaloneClientSetup.java

@@ -89,6 +90,8 @@ public Client setup() throws Exception {
            // .put("script.groovy.sandbox.enabled",
            // true)
            .put("discovery.zen.ping.multicast.enabled", false)
+            // Fixing path.home not configured error in unit test
+            .put("path.home", "/tmp/" + UUID.randomUUID())


udoprog · 2016-09-18T16:27:53Z

...t/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendV1.java

-import static org.elasticsearch.index.query.FilterBuilders.orFilter;
-import static org.elasticsearch.index.query.FilterBuilders.prefixFilter;
-import static org.elasticsearch.index.query.FilterBuilders.regexpFilter;
-import static org.elasticsearch.index.query.FilterBuilders.termFilter;


Prefer static imports.

udoprog · 2016-09-18T16:29:29Z

...elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendKV.java

-import static org.elasticsearch.index.query.FilterBuilders.notFilter;
-import static org.elasticsearch.index.query.FilterBuilders.orFilter;
-import static org.elasticsearch.index.query.FilterBuilders.prefixFilter;
-import static org.elasticsearch.index.query.FilterBuilders.termFilter;


Prefer static imports for the QueryBuilders API. It's how most of the API is documented and seems to be the preferred method.

udoprog · 2016-09-18T16:29:45Z

...elasticsearch/src/main/java/com/spotify/heroic/metadata/elasticsearch/MetadataBackendV1.java

-import static org.elasticsearch.index.query.FilterBuilders.notFilter;
-import static org.elasticsearch.index.query.FilterBuilders.prefixFilter;
-import static org.elasticsearch.index.query.FilterBuilders.regexpFilter;
-import static org.elasticsearch.index.query.FilterBuilders.termFilter;


Prefer static imports.

udoprog · 2016-09-18T16:29:51Z

...t/elasticsearch/src/main/java/com/spotify/heroic/suggest/elasticsearch/SuggestBackendKV.java

-import static org.elasticsearch.index.query.FilterBuilders.notFilter;
-import static org.elasticsearch.index.query.FilterBuilders.orFilter;
-import static org.elasticsearch.index.query.FilterBuilders.prefixFilter;
-import static org.elasticsearch.index.query.FilterBuilders.termFilter;


Prefer static imports.

udoprog · 2016-09-18T16:31:08Z

...elasticsearch-utils/src/main/java/com/spotify/heroic/elasticsearch/TransportClientSetup.java

-        final TransportClient client = new TransportClient(settings);
+        final TransportClient client = TransportClient.builder()
+            .settings(settings)
+            .addPlugin(DeleteByQueryPlugin.class)


I'm on the fringe about the use of this plugin. Will the client work (apart from the delete-by-query usage) if its not installed server side?

Alternatively, implement a query-then-delete functionality on the client which seems to be the recommended approach.

udoprog · 2017-06-01T15:09:39Z

Closing in favor of #267

dbrounst mentioned this pull request Jul 21, 2016

Support Elasticsearch 2.x #50

Closed

Changes to allow the use of Elasticsearch 2x.

b8f1672

dbrounst force-pushed the Elasticsearch-2x branch from 088bebf to b8f1672 Compare July 21, 2016 22:17

Changes to allow the use of Elasticsearch 2x. (spotify#1)

ca87b48

jcabmora mentioned this pull request Aug 4, 2016

StackOverflowError when running write-performance #64

Closed

teamcity and others added 8 commits September 6, 2016 11:49

Merge branch 'master' of https://github.com/spotify/heroic

bc16e0b

HeroicShell should return exit code 1 in case of errors

6ec9860

HeroicShell should return exit code 1 in case of errors

00b24c4

HeroicShell should return exit code 1 in case of errors

Merge branch 'master' of https://github.com/spotify/heroic

8be4d08

Fixed issues for full test suite. (spotify#3)

3445dbb

- Fixed issues for full test suite. - Fixed NOT query filter - Fixed "path.home" not configured issue for unit test.

Merge pull request spotify#1 from dbrounst/Elasticsearch-2x-github

16de3d5

Elasticsearch 2x GitHub

dbrounst force-pushed the Elasticsearch-2x branch from c504db9 to 11f66cf Compare September 16, 2016 17:25

Merge branch 'master' of https://github.com/spotify/heroic into Elast…

970a4e4

…icsearch-2x

udoprog suggested changes Sep 18, 2016

View reviewed changes

dbrounst added 6 commits September 19, 2016 20:37

Changes suggested by the Spotify team

3929a7c

merge

005c210

merge

11c1e61

Spotify Requested Changes

5727ef9

Spotify Requested Changes (2)

237b27e

merge

730f3b2

udoprog closed this Jun 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to allow the use of Elasticsearch 2x. #62

Changes to allow the use of Elasticsearch 2x. #62

dbrounst commented Jul 21, 2016

udoprog commented Jul 22, 2016

codecov-io commented Sep 16, 2016 •

edited

udoprog left a comment

udoprog Sep 18, 2016 •

edited

udoprog Sep 18, 2016

udoprog Sep 18, 2016 •

edited

udoprog Sep 18, 2016

udoprog Sep 18, 2016

udoprog Sep 18, 2016

udoprog Sep 18, 2016

udoprog commented Jun 1, 2017

Changes to allow the use of Elasticsearch 2x. #62

Changes to allow the use of Elasticsearch 2x. #62

Conversation

dbrounst commented Jul 21, 2016

udoprog commented Jul 22, 2016

codecov-io commented Sep 16, 2016 • edited

Current coverage is 20.15% (diff: 21.59%)

udoprog left a comment

Choose a reason for hiding this comment

udoprog Sep 18, 2016 • edited

Choose a reason for hiding this comment

udoprog Sep 18, 2016

Choose a reason for hiding this comment

udoprog Sep 18, 2016 • edited

Choose a reason for hiding this comment

udoprog Sep 18, 2016

Choose a reason for hiding this comment

udoprog Sep 18, 2016

Choose a reason for hiding this comment

udoprog Sep 18, 2016

Choose a reason for hiding this comment

udoprog Sep 18, 2016

Choose a reason for hiding this comment

udoprog commented Jun 1, 2017

codecov-io commented Sep 16, 2016 •

edited

udoprog Sep 18, 2016 •

edited

udoprog Sep 18, 2016 •

edited