Skip to content

Commit

Permalink
pep8 fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Erik Bernhardsson committed Jan 26, 2015
1 parent 942c61d commit 06ac494
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
6 changes: 4 additions & 2 deletions luigi/parameter.py
Expand Up @@ -323,17 +323,19 @@ def add_to_cmdline_parser(self, parser, param_name, task_name, optparse=False, g
dest=dest)

def parse_from_args(self, param_name, task_name, args, params):
# Note: modifies arguments
dest = self.parser_dest(param_name, task_name, glob=False)
if dest is not None:
value = getattr(args, dest, None)
params[param_name] = self.parse_from_input(param_name, value) # Note: modifies arguments
params[param_name] = self.parse_from_input(param_name, value)

def set_global_from_args(self, param_name, task_name, args):
# Note: side effects
dest = self.parser_dest(param_name, task_name, glob=True)
if dest is not None:
value = getattr(args, dest, None)
if value is not None:
self.set_global(self.parse_from_input(param_name, value)) # Note: side effects
self.set_global(self.parse_from_input(param_name, value))


class DateHourParameter(Parameter):
Expand Down
3 changes: 1 addition & 2 deletions luigi/rpc.py
Expand Up @@ -116,8 +116,7 @@ def get_work(self, worker, host=None):
'/api/get_work',
{'worker': worker, 'host': host},
log_exceptions=False,
attempts=1
)
attempts=1)

def graph(self):
return self._request('/api/graph', {})
Expand Down
2 changes: 1 addition & 1 deletion test/parameter_test.py
Expand Up @@ -120,7 +120,7 @@ class Banana(luigi.Task):

def requires(self):
if self.style is None:
return BananaDep() # will fail
return BananaDep() # will fail
elif self.style == 'x-arg':
return BananaDep(self.x)
elif self.style == 'y-kwarg':
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Expand Up @@ -24,7 +24,7 @@ commands =

[testenv:pep8]
deps = pep8
commands = /usr/bin/env bash -c 'pep8 --ignore E501 luigi test examples bin || true'
commands = pep8 --ignore E501 luigi test examples bin

This comment has been minimized.

Copy link
@themalkolm

themalkolm Jan 26, 2015

Contributor

👍


[testenv:autopep8]
deps = autopep8
Expand Down

0 comments on commit 06ac494

Please sign in to comment.