Make task.disable_window be default source of window int (#3081)

* Make task.disable_window be default source of window int * Add test on disable_window_seconds
spotify · Aug 22, 2021 · 62c12d1 · 62c12d1
1 parent cf4b6fb
commit 62c12d1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/luigi/task.py b/luigi/task.py
@@ -218,12 +218,12 @@ def disable_window(self):
         Override this positive integer to have different ``disable_window`` at task level.
         Check :ref:`scheduler-config`
         """
-        return self.disable_window_seconds
+        return None
 
     @property
     def disable_window_seconds(self):
         warnings.warn("Use of `disable_window_seconds` has been deprecated, use `disable_window` instead", DeprecationWarning)
-        return None
+        return self.disable_window
 
     @property
     def owner_email(self):

diff --git a/test/task_test.py b/test/task_test.py
@@ -152,6 +152,15 @@ class MockTimedelta:
         with self.assertWarnsRegex(UserWarning, 'Parameter "timedelta_param" with value ".*" is not of type timedelta.'):
             DummyTask(**params)
 
+    def test_disable_window_seconds(self):
+        """
+        Deprecated disable_window_seconds param uses disable_window value
+        """
+        class ATask(luigi.Task):
+            disable_window = 17
+        task = ATask()
+        self.assertEqual(task.disable_window_seconds, 17)
+
 
 class ExternalizeTaskTest(LuigiTestCase):