get_work optimizations #1046
Merged
get_work optimizations #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the computation of number of dependents from the rank function, as it's one of the more expensive parts of get_work and probably doesn't make much of a difference anyway.
It doesn't really make sense to keep traversing past DONE tasks to find upstream status, so this change avoids looking at dependents of DONE tasks when computing upstream dependencies. This can save a lot of time in get_work if there are many DONE tasks with lots of dependencies.
After finding best_task, get_work can return immediately, except that it needs to compute the number of PENDING tasks. However, it still does a lot of other unnecessary work. This speeds up get_work by checking earlier whether a best_task has been found yet and skipping the other work if so.
|
LGTM. Very nice that you split up the commits. I really want to merge. Anyone else wants to review first? |
|
LGTM |
|
Thanks @daveFNbuck! :) |
|
No problem. I hope this works well for you guys too. On Wed, Jul 8, 2015 at 5:13 AM, Arash Rouhani notifications@github.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines three optimizations for get_work. The first one removes the number of dependencies computation from ranking, as I noticed that this was a large component of get_work time and I no longer think it makes much of a difference overall. Next, I limit upstream_status computation to not look past DONE tasks, giving a decent performance boost when many tasks are DONE. Finally, I remove unnecessary computation in get_work that occurs after finding a best_task.