AWS EC2 Container Service support #1317
Conversation
|
ah ok, just realized master is failing too. Will rebase and try again once that's fixed up |
|
|
||
| Requires: | ||
| * boto3 package | ||
| * Amazon AWS credentials discoverable by boto3 (e.g., by using `aws configure` |
There was a problem hiding this comment.
Have you checked that the docs render properly? You can use tox to generate docs too: https://github.com/spotify/luigi/blob/master/CONTRIBUTING.rst#writing-documentation
|
Tests and docs included. Awesome! Can you just amend and rebase and fix the minor issues I pointed out? |
From the AWS website, > Amazon EC2 Container Service (ECS) is a highly scalable, high performance > container management service that supports Docker containers and allows you > to easily run applications on a managed cluster of Amazon EC2 instances. To use ECS, you create a "task definition" JSON that defines the `docker run` command for one or more containers in a task or service, and then submit this JSON to the API to run the task. This wrapper allows you to create Luigi Tasks to submit ECS `taskDefinition`s. You can either pass a dict (mapping directly to the `taskDefinition` JSON) or an Amazon Resource Name (arn) for a previously registered `taskDefinition`. Testing was performed on the default cluster created through the ECS console [first run wizard](https://console.aws.amazon.com/ecs/home#/firstRun) Requires boto3, configured with valid AWS credentials
|
thanks for the advice, docs are reformatted from markdown to reStructuredText and look much better now. Rebased, tox passes locally. Should be all set. |
|
Thanks!! :) |
|
I don't see how this can harm the 2.0 release. So merging. |
AWS EC2 Container Service support
|
cool, thanks! Glad to have made it into 2.0! On Thu, Oct 22, 2015 at 9:20 AM, Arash Rouhani notifications@github.com
Jacob Feala, PhD [This e-mail message may contain privileged, confidential and/or |
From the AWS website,
To use ECS, you create a "task definition" JSON that defines the
docker runcommand for one or more containers in a task or service, and then submit this JSON to the API to run the task.This wrapper allows you to create Luigi Tasks to submit ECS tasks. You can either pass a dict (mapping directly to the
taskDefinitionJSON) or an Amazon Resource Name (arn) for a previously registeredtaskDefinition.Testing was performed on the default cluster created through the ECS console first run wizard
Requires boto3, configured with valid AWS credentials